[FFmpeg-devel] [PATCH] Optimize QTRLE encoding

Malcolm Bechard malcolm.bechard at gmail.com
Wed Feb 20 22:59:41 CET 2013


On Sun, Feb 17, 2013 at 12:06 PM, Malcolm Bechard <malcolm.bechard at gmail.com
> wrote:

> > Ok, here's an update with that removed.
>> >
>> > Malcolm
>>
>> >  qtrleenc.c |   87
>> ++++++++++++++++++++++++++++++++++++++++++++++---------------
>> >  1 file changed, 67 insertions(+), 20 deletions(-)
>> > c88603b1c5e1ec4a7ec66add209069e03c66b662
>>  0001-Improve-QTRLE-encoding-performance-no-change-to-outp.patch
>> > From 0af76909ff8bc12264451ad2df74f02df65ab5ce Mon Sep 17 00:00:00 2001
>> > From: Malcolm Bechard <malcolm.bechard at gmail.com>
>> > Date: Fri, 15 Feb 2013 10:53:27 -0500
>> > Subject: [PATCH] Improve QTRLE encoding performance, no change to
>> output file
>> >  size/content.
>> >
>> > Avoid searching for the lowest bulk cost for each pixel that isn't a
>> repeat/skip. Instead store the lowest cost as we go along each pixel, and
>> use it as needed.
>>
>> this patch breaks make fate
>>
>> --- ./tests/ref/vsynth/vsynth2-qtrle    2013-02-17 13:57:19.199049065+0100
>> +++ tests/data/fate/vsynth2-qtrle   2013-02-17 17:18:05.771302853 +0100
>> @@ -1,4 +1,4 @@
>> -f2aea57de225cccadb936bba4086a836 *tests/data/fate/vsynth2-qtrle.mov
>> -14798345 tests/data/fate/vsynth2-qtrle.mov
>> +c63c8c5e96bd0103c8494f0081fde689 *tests/data/fate/vsynth2-qtrle.mov
>> +14798495 tests/data/fate/vsynth2-qtrle.mov
>>  98d0e2854731472c5bf13d8638502d0a
>> *tests/data/fate/vsynth2-qtrle.out.rawvideo
>>  stddev:    1.26 PSNR: 46.10 MAXDIFF:   13 bytes:  7603200/  7603200
>>
>>
>> [...]
>> --
>> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>>
>> What does censorship reveal? It reveals fear. -- Julian Assange
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>>
> I'll get my environment sorted out so I can run make fate and fix this.
>
> Malcolm
>

Ok this is now fixed, was Integer overflow bug. No change to the
performance increase. Sorry about that.

Malcolm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Improve-QTRLE-encoding-performance-no-change-to-outp.patch
Type: application/octet-stream
Size: 5461 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130220/3cecc2da/attachment.obj>


More information about the ffmpeg-devel mailing list