[FFmpeg-devel] [PATCH] lavfi/decimate: use named options

Stefano Sabatini stefasab at gmail.com
Wed Feb 20 19:15:24 CET 2013


On date Wednesday 2013-02-20 15:16:50 +0100, Clément Bœsch encoded:
> On Wed, Feb 20, 2013 at 03:03:12PM +0100, Stefano Sabatini wrote:
> > TODO: bump micro
> > ---
> >  doc/filters.texi          |   23 +++++++++++++---------
> >  libavfilter/vf_decimate.c |   48 ++++++++++++++++++++++++---------------------
> >  2 files changed, 40 insertions(+), 31 deletions(-)
> > 
> > diff --git a/doc/filters.texi b/doc/filters.texi
> > index 43bfd9c..3be8363 100644
> > --- a/doc/filters.texi
> > +++ b/doc/filters.texi
> > @@ -2069,11 +2069,14 @@ for very-low-bitrate encoding (e.g. streaming over dialup modem), but
> >  it could in theory be used for fixing movies that were
> >  inverse-telecined incorrectly.
> >  
> > -It accepts the following parameters:
> > - at var{max}:@var{hi}:@var{lo}:@var{frac}.
> > +The filter accepts parameters as a list of @var{key}=@var{value}
> > +pairs, separated by ":".  If the key of the first options is omitted,
> > +the arguments are interpreted according to the syntax:
> > + at option{max}:@option{hi}:@option{lo}:@option{frac}.
> >  
> 
> Isn't this "@option{max}[:@option{hi}[:@option{lo}[:@option{frac}]]]"?

Yes but seems overkill.

> 
> Note: we definitely need a common documentation template for all of them.

I plan to do it when all filters will support named options.

[...] 

> LGTM anyway, thanks

Pushed with some very minor fixes, thanks.
-- 
FFmpeg = Furious and Fierce Muttering Proud Exxagerate Goblin


More information about the ffmpeg-devel mailing list