[FFmpeg-devel] [PATCH] x86/dsputil: fix compilation when h263 decoder/encoder are disabled.

[Paul B Mahol]

On 2/18/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Feb 18, 2013 at 12:38:02PM +0000, Paul B Mahol wrote:
>> On 2/18/13, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Sun, Feb 17, 2013 at 06:20:17PM -0800, Ronald S. Bultje wrote:
>> >> From: "Ronald S. Bultje" <rsbultje at gmail.com>
>> >>
>> >> The symbol "ff_h263_loop_filter_strength" is defined in h263.c, but
>> >> the h263 loopfilter functions (in the .asm file) are not optimized
>> >> out (even though their function pointers are never assigned).
>> >> ---
>> >>  libavcodec/x86/dsputil.asm | 3 ++-
>> >>  1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > This breaks building of mplayer
>>
>> That is another project.
>
> Thats absolutely true but still no reason to break it if it can be
> avoided easily

I do not have mplayer installed, and thus I can not follow this.

It is just bogus to mention such thing at all.

>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> It is what and why we do it that matters, not just one of them.
>