[FFmpeg-devel] [PATCH]Fix compilation without fft on arm

Geek.Song ffmpeg at gmail.com
Mon Feb 18 02:59:55 CET 2013


On Mon, Feb 18, 2013 at 12:36 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> Gavin Kinsey <gkinsey <at> ad-holdings.co.uk> writes:
>
> > With patch compiles correctly.
>
> Patch applied.
>

As mentioned in my previous mail, the patch is not elegant,

fft_fixed_init_arm.c and fft_init_arm.c is FFT related codes, they need not
to be protected by CONFIG_FFT. if FFT is not enabled , they should not be
compiled.

IMHO, the following patch is better than the committed patch.

-----------------------------------------------------------------------------------------
My key fingerprint: d1:03:f5:32:26:ff:d7:3c:e4:42:e3:51:ec:92:78:b2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fft_arm_compile_selectable.diff
Type: application/octet-stream
Size: 1306 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130218/e6702ea6/attachment.obj>


More information about the ffmpeg-devel mailing list