[FFmpeg-devel] [PATCH 2/2] lavc/tta: Don't drop the result of the header crc

[Paul B Mahol]

On 2/16/13, James Almer <jamrial at gmail.com> wrote:
> On 16/02/13 8:11 AM, Paul B Mahol wrote:
>> On 2/16/13, James Almer <jamrial at gmail.com> wrote:
>>>
>>> Signed-off-by: James Almer <jamrial at gmail.com>
>>> ---
>>>  libavcodec/tta.c | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/libavcodec/tta.c b/libavcodec/tta.c
>>> index 4240946..48ee914 100644
>>> --- a/libavcodec/tta.c
>>> +++ b/libavcodec/tta.c
>>> @@ -213,7 +213,8 @@ static av_cold int tta_decode_init(AVCodecContext *
>>> avctx)
>>>      {
>>>          if (avctx->err_recognition & AV_EF_CRCCHECK) {
>>>              s->crc_table = av_crc_get_table(AV_CRC_32_IEEE_LE);
>>> -            tta_check_crc(s, avctx->extradata, 18);
>>> +            if (tta_check_crc(s, avctx->extradata, 18))
>>> +                return AVERROR_INVALIDDATA;
>>>          }
>>>
>>>          /* signature */
>>> --
>>> 1.7.12.4
>>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel at ffmpeg.org
>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>
>> Rejected. Please do your homework and read log history for that file.
>
> I see. Apologies, then.

The result could still be used if you wrote patch
that does not break tta in matroska.....

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>