[FFmpeg-devel] [PATCH] lavc/flacdec: Add frame CRC calculation

[compn]

On Sun, 17 Feb 2013 01:30:57 +0100, Michael Niedermayer wrote:
>On Sat, Feb 16, 2013 at 08:56:18PM -0300, James Almer wrote:
>> On 16/02/13 8:45 PM, Michael Niedermayer wrote:
>> > On Sat, Feb 16, 2013 at 06:07:49AM -0300, James Almer wrote:
>> >> Fixes ticket #2266
>> >>
>> >> Signed-off-by: James Almer <jamrial at gmail.com>
>> > 
>> > does this improve or worsen the way damaged files sound ?
>> > 
>> > (the check is enabled be default if i didnt  misread teh code)
>> 
>> Like in other decoders, the damaged frame is discarded but the
>> decoding is not interrupted.
>
>thats not awnsering my question
>my goal here is that the default should be what sounds best, in the
>sense of a human listening to A and B and saying "i prefer A"
>loud pops, clicks and squeeks would be annoying so would be missing
>information.
>and repeating the last good audio frame could sound better than
>silence
>
>adding support for (non default enabled) crc checking is certainly
>ok OTOH ..

i remember an old change to ac3 decoder (maybe it was liba52 not ffac3)
where a commit enabled decoding only if crc matched, but a lot of
samples didnt have crc info. the result was a lot of files didnt have
any audio after the change.

-compn