[FFmpeg-devel] [PATCH] lavfi/unsharp: add missing NULL check

Paul B Mahol onemda at gmail.com
Fri Feb 15 20:15:50 CET 2013


On 2/15/13, Stefano Sabatini <stefasab at gmail.com> wrote:
> ---
>  libavfilter/vf_unsharp.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavfilter/vf_unsharp.c b/libavfilter/vf_unsharp.c
> index 51f44c8..e8f162b 100644
> --- a/libavfilter/vf_unsharp.c
> +++ b/libavfilter/vf_unsharp.c
> @@ -211,7 +211,8 @@ static int init_filter_param(AVFilterContext *ctx,
> FilterParam *fp, const char *
>             effect, effect_type, fp->msize_x, fp->msize_y, fp->amount /
> 65535.0);
>
>      for (z = 0; z < 2 * fp->steps_y; z++)
> -        fp->sc[z] = av_malloc(sizeof(*(fp->sc[z])) * (width + 2 *
> fp->steps_x));
> +        if (!(fp->sc[z] = av_malloc(sizeof(*(fp->sc[z])) * (width + 2 *
> fp->steps_x))))
> +            return AVERROR(ENOMEM);
>
>      return 0;
>  }
> --
> 1.7.9.5
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

Is leak possible? LGTM anyway.


More information about the ffmpeg-devel mailing list