[FFmpeg-devel] [PATCH]Show mxf Universal Label with loglevel verbose

[Tomas Härdin]

On Tue, 2013-01-29 at 14:43 +0100, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes ticket #2198.
> 
> Please comment, Carl Eugen


> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index 648a579..029809a 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -1506,6 +1506,12 @@ static int mxf_parse_structural_metadata(MXFContext *mxf)
>          /* TODO: drop PictureEssenceCoding and SoundEssenceCompression, only check EssenceContainer */
>          codec_ul = mxf_get_codec_ul(ff_mxf_codec_uls, &descriptor->essence_codec_ul);
>          st->codec->codec_id = (enum AVCodecID)codec_ul->id;
> +        av_log(mxf->fc, AV_LOG_VERBOSE, "%s: Universal Label: 0x",
> +               avcodec_get_name(st->codec->codec_id));

Do we need the "0x"? It's unstandard. I'd say go with the pure UL in
unspaced hex or use the SMPTE standard notation (hex groups separated by
dots). The latter looks like this (from
http://www.freemxf.org/mxflib-docs/mxflib-1.0.0-docs/dict_8h-source.html):

 060E2B34.0104.0101.01010500.00000000

I'm comfortable with either of those. The "0x" interferes with a tool of
mine I've been meaning to release, for dealing with ULs.

/Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130211/0eb07a19/attachment.asc>