[FFmpeg-devel] [PATCH] h264: integrate clear_blocks calls with IDCT.

[Michael Niedermayer]

On Sat, Feb 09, 2013 at 08:49:56AM -0800, Ronald S. Bultje wrote:
> Hi,
> 
> On Fri, Feb 8, 2013 at 4:51 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Thu, Feb 07, 2013 at 10:20:52PM -0800, Ronald S. Bultje wrote:
> >> From: "Ronald S. Bultje" <rsbultje at gmail.com>
> >>
> >> In case of no-transform, integrate it with put_pixels4/8(). In case
> >> of intra PCM, do an explicit memset(0) call. Together, this makes
> >> the H264 decoder almost-independent of dsputil.
> >>
> >> (PPC and Arm assembly not yet ported.)
> >
> > breaks fate-h264-lossless
> 
> I tried this in various ways, and can't reproduce. What system/config?

linux core i7

still fails with HEAD:
--- ./tests/ref/fate/h264-lossless  2013-02-02 17:49:11.519087938 +0100
+++ tests/data/fate/h264-lossless   2013-02-09 22:14:32.065115871 +0100
@@ -1,11 +1,11 @@
 #tb 0: 83333/5000000
-0,          0,          0,        1,   460800, 0x7731dd2f
-0,          2,          2,        1,   460800, 0x944b8c64
-0,          3,          3,        1,   460800, 0xbe833041
-0,          4,          4,        1,   460800, 0xbe95d96a
-0,          5,          5,        1,   460800, 0xfe7ea5e6
-0,          6,          6,        1,   460800, 0x381743c7
-0,          7,          7,        1,   460800, 0x63fcc2e9
-0,          8,          8,        1,   460800, 0x79574960
-0,          9,          9,        1,   460800, 0xdab9e18a
-0,         10,         10,        1,   460800, 0xd88e8fe8
+0,          0,          0,        1,   460800, 0xa40e9b4e
+0,          2,          2,        1,   460800, 0x3ac9f364
+0,          3,          3,        1,   460800, 0x38e73edf
+0,          4,          4,        1,   460800, 0x97bb08b0
+0,          5,          5,        1,   460800, 0xd16f4b6d
+0,          6,          6,        1,   460800, 0x00f724f4
+0,          7,          7,        1,   460800, 0x8b0d742b
+0,          8,          8,        1,   460800, 0xddda09dc
+0,          9,          9,        1,   460800, 0x7b7e80b5
+0,         10,         10,        1,   460800, 0xb3243355
Test h264-lossless failed. Look at tests/data/fate/h264-lossless.err for details.

-cpuflags 0 makes no difference, valgrind shows nothing
vissually with ffplay the most vissible effect are white pixels in
dark areas.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130209/58b1ac4a/attachment.asc>