[FFmpeg-devel] [PATCH] vdpau: Rename union, avoid name conflict with vdpau

Michael Niedermayer michaelni at gmx.at
Tue Feb 5 21:22:32 CET 2013


On Tue, Feb 05, 2013 at 09:14:09PM +0100, Reimar Döffinger wrote:
> 
> 
> On 5 Feb 2013, at 20:18, Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > Fixes Ticket2203
> > 
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> > libavcodec/vdpau.h |    6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/libavcodec/vdpau.h b/libavcodec/vdpau.h
> > index 7933a79..df2aace 100644
> > --- a/libavcodec/vdpau.h
> > +++ b/libavcodec/vdpau.h
> > @@ -52,7 +52,7 @@
> > #include <vdpau/vdpau.h>
> > #include <vdpau/vdpau_x11.h>
> > 
> > -union VdpPictureInfo {
> > +union FFVdpPictureInfo {
> 
> Since vdpau.h is an installed header, should it be AV instead of FF?
> Or if its FF because people should not rely on the name of the union maybe that should be said in a comment?

we can esily change from FF to AV but not the other way around due
to that removing a public type, which is why i choose FF

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130205/ff7a203d/attachment.asc>


More information about the ffmpeg-devel mailing list