[FFmpeg-devel] [PATCH] lavu/rational: add syntactic sugar.

Nicolas George george at nsup.org
Tue Dec 31 19:51:24 CET 2013

Le primidi 11 nivôse, an CCXXII, Michael Niedermayer a écrit :
> i dont like these defines, they hide the actual values and can make
> it harder to understand code
> (of course not for us here now as we see the defines first but a
>  reader who reads a mix of av_make_q() and AV_*_Q has to look 2+
>   things up instead of one)
> we also dont use
> #define FIVE 5
> #define ONE 1
> and such

My idea was to make things more explicit, especially for the 1/0 and 0/0
cases (they are not used completely consistently as placeholder in the
code), but your argument makes sense too.

> but av_make_q(), is a brilliant idea IMHO

Thanks. New patch series attached, with version bump, APIchanges entry, and
constants removed, all concatenated just for review.

Built and FATEd, except crystalhd.c and dshow.c.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: av_make_q.patch
Type: text/x-diff
Size: 86066 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131231/16d0054b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131231/16d0054b/attachment.asc>

More information about the ffmpeg-devel mailing list