[FFmpeg-devel] [PATCH 1/2] avutil: Add av_get_time_base{_q, }() and deprecate AV_TIME_BASE{_Q, }

Derek Buitenhuis derek.buitenhuis at gmail.com
Mon Dec 30 20:38:36 CET 2013

On 12/30/2013 4:39 PM, Clément Bœsch wrote:
> I don't think they are supposed to be changed, and if you change them, it
> will likely break a lot of things. I don't think those macro hurts until
> we need to change the value. No need to break the ABI for the sole purpose
> of avoiding unsure ABI break in the future.

I think it's fairly silly to have multiple things that do the same thing, but
I am not going to have a big argument over it.

> I'm al'right with that. But in that case, just add the two helpers for C++
> apps and don't drop anything. It won't break anything, and it makes the
> huge second patch unnecessary.

Even if it is dropped, there is one part which should still be fixed:

The abuse of AV_TIME_BASE_Q by using &AV_TIME_BASE_Q, which is pretty
ugly IMO and relies on internal knowledge of its definition, which isn't
so kosher.

The other thing is: The Libav side has already run with my patch. It isn't merged
yet, but someone other than myself is championing it. Don't know how you want to
handle that "fun" business.

- Derek

More information about the ffmpeg-devel mailing list