[FFmpeg-devel] [PATCH] vqavideo: add comment to a specific error case.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon Dec 30 12:45:41 CET 2013


The way we handle it currently is not idea from an error resilience
standpoint.

Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
---
 libavcodec/vqavideo.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavcodec/vqavideo.c b/libavcodec/vqavideo.c
index 9133855..1be7351 100644
--- a/libavcodec/vqavideo.c
+++ b/libavcodec/vqavideo.c
@@ -534,6 +534,10 @@ static int vqa_decode_chunk(VqaContext *s, AVFrame *frame)
     if ((cbp0_chunk != -1) && (cbpz_chunk != -1)) {
         /* a chunk should not have both chunk types */
         av_log(s->avctx, AV_LOG_ERROR, "problem: found both CBP0 and CBPZ chunks\n");
+        /* This is a bit questionable since it really means the
+         * following frames will be broken, not the current one,
+         * might be better to just ignore it or even better
+         * only process CBPZ which should contain a full codebook */
         return AVERROR_INVALIDDATA;
     }
 
-- 
1.8.5.2



More information about the ffmpeg-devel mailing list