[FFmpeg-devel] [PATCH 3/7] lavc/utils: check av_frame_alloc() failure.

Michael Niedermayer michaelni at gmx.at
Mon Dec 30 03:48:18 CET 2013

On Sun, Dec 29, 2013 at 07:13:53PM +0100, Michael Niedermayer wrote:
> On Sun, Dec 29, 2013 at 05:30:18PM +0100, Nicolas George wrote:
> > Le nonidi 9 nivôse, an CCXXII, Michael Niedermayer a écrit :
> > > LGTM if the error pathes where tested under valgrind or similar
> > 
> > It was hard, because they are old APIs and there are no tests for them.
> > 
> > Also, avcodec_decode_audio3() is currently broken, see the attached patch.
> hmm, this doesnt set s->release_buffer= avcodec_default_release_buffer;
> is that intended ?
> A user app could have set
> s->release_buffer= avcodec_default_release_buffer; or equivalent

I possibly worded this unclearly
what i meant was that if setting
release_buffer= avcodec_default_release_buffer
causes some problem then an application that calls
avcodec_default_release_buffer from its release_buffer implementation
would also cause the problem, and not setting release_buffer would
likely leak and i saw one case where its called without a null
pointer check so it could crash

but maybe iam missing something, can you elaborate about the issue
you found ?



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131230/439cc402/attachment.asc>

More information about the ffmpeg-devel mailing list