[FFmpeg-devel] [PATCH 1/2] avutil: Add av_get_time_base{_q, }() and deprecate AV_TIME_BASE{_Q, }

Michael Niedermayer michaelni at gmx.at
Mon Dec 30 02:58:27 CET 2013

On Sun, Dec 29, 2013 at 11:35:37PM +0000, Derek Buitenhuis wrote:
> It was never a good idea to have tehse values as defines in the first place,
> since they are internal values, and may change.

they start with a AV_ prefix and are in a public header, so the
statement that they ARE "internal values, and may change" is
certainly not correct.
Also there are several public fields that use them as timebase

> This also fixes the impossibility of using AV_TIME_BASE_Q in pre-C99/C++
> applications, which cannot use compound literals directly in their code.

that explains the addition of a function returning the timebase,
i agree that this part (or something equivalent) is needed

I dont understand why the defines are deprecated though, can you
elaborate on why you change that ?

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131230/53d8456a/attachment.asc>

More information about the ffmpeg-devel mailing list