[FFmpeg-devel] Patch: Inline asm fixes for Intel compiler on Windows

[Carl Eugen Hoyos]

Matt Oliver <protogonoi <at> gmail.com> writes:

[...]

> -        "pmullw "MANGLE(MUL2)", %%mm7\n\t"\
> +        "pmullw "#MUL2", %%mm7      \n\t"\

Does this fail at compile time or link time?
Is is really impossible to make MANGLE() compatible?

> +#if !defined(__INTEL_COMPILER)
> +          , "%"REG_SP
> +#endif

(Sorry if this is obvious.)
Why is this not under 
"!( defined(__INTEL_COMPILER) && defined(_MSC_VER) )"?


> -//MMX versions
> -#if HAVE_MMX_INLINE
> -#undef RENAME
> -#undef COMPILE_TEMPLATE_MMXEXT
> -#define COMPILE_TEMPLATE_MMXEXT 0
> -#define RENAME(a) a ## _MMX
> -#include "yuv2rgb_template.c"
> -#endif /* HAVE_MMX_INLINE */
> -
>  // MMXEXT versions
>  #if HAVE_MMXEXT_INLINE
>  #undef RENAME
> @@ -66,6 +57,15 @@
>  #include "yuv2rgb_template.c"
>  #endif /* HAVE_MMXEXT_INLINE */
>
> +//MMX versions
> +#if HAVE_MMX_INLINE
> +#undef RENAME
> +#undef COMPILE_TEMPLATE_MMXEXT
> +#define COMPILE_TEMPLATE_MMXEXT 0
> +#define RENAME(a) a ## _MMX
> +#include "yuv2rgb_template.c"
> +#endif /* HAVE_MMX_INLINE */
> +

Is this related / intended?

Carl Eugen