[FFmpeg-devel] [RFC]Add show_banner option

Carl Eugen Hoyos cehoyos at ag.or.at
Sat Dec 28 02:29:11 CET 2013

Michael Niedermayer <michaelni <at> gmx.at> writes:

> >  libavcodec/xsubenc.c   |    5 +++++
> hmm

I believe the test in line 145 of xsubenc.c is wrong and 
should either be:
if (((uint32_t *)h->rects[0]->pict.data[1])[0] >> 24 & 0xff)
or more likely:
if (AV_RN32(h->rects[0]->pict.data[1]) & 0xff000000)
(or something similar).

With the fix, ticket #3247 is an enhancement request.
(I will improve the ticket, it is currently needlessly hard 
to reproduce.)

> no objections to the rest

Patch sent.

Carl Eugen

More information about the ffmpeg-devel mailing list