[FFmpeg-devel] [PATCH] Fix start_time in MKV Demuxer
alx.sukhanov at gmail.com
Mon Dec 23 10:46:17 CET 2013
On Sun, Dec 22, 2013 at 4:27 PM, Michael Niedermayer <michaelni at gmx.at>wrote:
> On Sun, Dec 22, 2013 at 02:28:46AM +0000, Carl Eugen Hoyos wrote:
> > Michael Niedermayer <michaelni <at> gmx.at> writes:
> > > yes, the checksums change in your patch, why do they change ?
> > > I applied your patch locally now and i do not see this change for
> > > vp9-parallelmode-akiyo
> > > so if i would apply the patch it would break fate for me and if i
> > > would apply it without the vp9-parallelmode-akiyo hunk it likely
> > > would break fate for you, id assume.
> > My guess is that Alex tests on a multi-core system where
> > this test is not supposed to work correctly atm.
> this would explain it but
> make V=2 fate-vp9-parallelmode-akiyo
> seems to use
> -threads 1
> unless one overrides that
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> The bravest are surely those who have the clearest vision
> of what is before them, glory and danger alike, and yet
> notwithstanding go out to meet it. -- Thucydides
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
Yes, I used fate with THREADS=4 (or even 8), sorry don't remember exactly.
I actually wanted to speed up the testing and I thought that "threads"
means how many test I want to run at the same time.
Thanks for checking my change manually and preventing me from breaking
I prepared v2 version of my patch, where there is no vp9 test expectation
More information about the ffmpeg-devel