[FFmpeg-devel] [PATCH 1/1] h264: remove skip of h264 parsing independent of skip_frame

[Joakim Plate]

Current code would end up providing invalid timestamps if always run with
NONREF since has_b_frames would be setup wrongly, so calculated dts from
pts would be wrong.

Also, having AVDISCARD_ALL be less discarding than NONREF seem a bit
strange.


On Mon, Dec 16, 2013 at 2:07 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> Joakim Plate <elupus <at> ecce.se> writes:
>
> > This give a small performance hit since we do complete stream
> > parsing. The actual slice decoding of frame's are still skipped.
> >
> > With this change, decoder can be set to AVDISCARD_ALL and still
> > calculate has_b_frame and similar fields correctly.
>
> If this is so important, why not only skip the "continue"
> for AVDISCARD_ALL (which makes little sense anyway)? I
> suspect people setting NONREF really need that little
> performance win.
>
> Carl Eugen
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>