[FFmpeg-devel] [PATCH 1/2] avfilter/buffersrc: specify pixel format min/max

Nicolas George george at nsup.org
Sat Dec 7 16:09:56 CET 2013


Le septidi 17 frimaire, an CCXXII, Michael Niedermayer a écrit :
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  libavfilter/buffersrc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c
> index 6b6210d..8cdbc5d 100644
> --- a/libavfilter/buffersrc.c
> +++ b/libavfilter/buffersrc.c
> @@ -326,7 +326,7 @@ static const AVOption buffer_options[] = {
>      { "width",         NULL,                     OFFSET(w),                AV_OPT_TYPE_INT,      { .i64 = 0 }, 0, INT_MAX, V },
>      { "video_size",    NULL,                     OFFSET(w),                AV_OPT_TYPE_IMAGE_SIZE,                .flags = V },
>      { "height",        NULL,                     OFFSET(h),                AV_OPT_TYPE_INT,      { .i64 = 0 }, 0, INT_MAX, V },
> -    { "pix_fmt",       NULL,                     OFFSET(pix_fmt),          AV_OPT_TYPE_PIXEL_FMT,                 .flags = V },
> +    { "pix_fmt",       NULL,                     OFFSET(pix_fmt),          AV_OPT_TYPE_PIXEL_FMT,{ .i64 =-1 },-1, AV_PIX_FMT_NB-1, .flags = V },
>  #if FF_API_OLD_FILTER_OPTS
>      /* those 4 are for compatibility with the old option passing system where each filter
>       * did its own parsing */

Does it make any practical difference? I am a bit unsure about having in the
lavfi binary a hardcoded value that can become obsolete after a minor
upgrade of lavu.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131207/1be9341d/attachment.asc>


More information about the ffmpeg-devel mailing list