[FFmpeg-devel] [PATCH 2/2] lavc/dvdsub_parser: parse start and end times.

Michael Niedermayer michaelni at gmx.at
Fri Dec 6 01:10:59 CET 2013

On Fri, Dec 07, 2012 at 05:58:45PM +0100, Nicolas George wrote:
> Set the packet duration according to the times in it.
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  libavcodec/dvdsub_parser.c |   51 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
> Without this patch (and the previous one, since otherwise the time base is
> not set), ffmpeg -i foo.vob -c copy bar.mkv will not work because the
> subtitles packets do not have their duration; mkvalidator considers the file
> invalid and mkvmerge does not see the tracks.
> As a side note, I would very much like to understand how the PTS is supposed
> to work with parsers, since lavf assumes the PTS are in stream time base but
> the time base is not available.
> diff --git a/libavcodec/dvdsub_parser.c b/libavcodec/dvdsub_parser.c
> index e50c339..e451bdc 100644
> --- a/libavcodec/dvdsub_parser.c
> +++ b/libavcodec/dvdsub_parser.c

this patch seems to still apply cleanly, what is its status ?

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131206/b15cf1c2/attachment.asc>

More information about the ffmpeg-devel mailing list