[FFmpeg-devel] [PATCH]Support ac-3 in sfd

[Michael Niedermayer]

On Sun, Dec 01, 2013 at 05:15:33AM +0100, Carl Eugen Hoyos wrote:
> On Sunday 01 December 2013 03:14:17 am Michael Niedermayer wrote:
> > On Sat, Nov 30, 2013 at 02:14:47AM +0100, Carl Eugen Hoyos wrote:
> > > Hi!
> > >
> > > Attached patch fixes ticket #3184 for me.
> 
> > >      } else if (startcode >= 0x1c0 && startcode <= 0x1df) {
> > >          type = AVMEDIA_TYPE_AUDIO;
> > > -        codec_id = m->sofdec > 0 ? AV_CODEC_ID_ADPCM_ADX :
> > > AV_CODEC_ID_MP2; +        if (m->sofdec) {
> > > +            switch (startcode) {
> > > +            case 0x1c1:
> > > +                codec_id = AV_CODEC_ID_AC3;
> > > +                break;
> > > +            default:
> > > +                codec_id = AV_CODEC_ID_ADPCM_ADX;
> > > +            }
> >
> > i doubt a bit that this is the correct way to identify the codec
> 
> You are right, it breaks at least one of our samples.
> 
> New patch attached.
> 
> Please comment, Carl Eugen

LGTM

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131201/acf55654/attachment.asc>