[FFmpeg-devel] [PATCH] TLS OPENSSL SSL_get_error

Carl Eugen Hoyos cehoyos at ag.or.at
Thu Aug 29 14:53:36 CEST 2013


Mirko Puliafito <mirko.puliafito <at> gmail.com> writes:

> Patch attached

I cannot test atm, but are you sure the patch can be 
applied with "patch -p1"? It looks broken / mangled.

Please use tools/patcheck (indentation is off).

And please either use a switch for all four cases (the 
three existing ones and the new one) or an if-else 
block for the new case.

Finally, please consider to commit your patch locally, 
you can use git format-patch to produce a file that the 
maintainer can directly commit to his branch (without 
additional effort).

Carl Eugen



More information about the ffmpeg-devel mailing list