[FFmpeg-devel] [PATCH] lavc: make invalid UTF-8 in subtitle output a non-fatal error

wm4 nfxjfg at googlemail.com
Sat Aug 10 14:09:03 CEST 2013

On Sat, 10 Aug 2013 11:58:15 +0200
Nicolas George <nicolas.george at normalesup.org> wrote:

> Le duodi 22 thermidor, an CCXXI, Reimar Döffinger a écrit :
> > It would help far more if you could try to figure out what
> > the main objections are and to come up with a compromise
> My main objection here is that wm4's requests are unnecessary because the
> API already allows to do it more elegantly, just not the way wm4 had in
> mind. It does not require a patch on ffmpeg's part.
> >     For example we should ideally make a better job of providing
> > useful output for those applications that do _not_ want to
> > reimplement charset detection/conversion.
> That is what my recent patch series is about. With it, srtdec (and easily
> enough, the other text subtitles demuxers) can read UTF-8, ISO-8859-1,
> and UTF-16 and UCS-4 if a BOM is present, and they would be able to read
> other legacy encodings as soon as we decide how the user must select it.

The new patches are even worse because not only is it hilariously broken
and insufficient, and doesn't even allow the application to work around
ffmpeg's broken behavior by processing the data before passing it to
libavcodec. Sorry for speaking the truth so blatantly.

More information about the ffmpeg-devel mailing list