[FFmpeg-devel] should ff_rtp_codec_id() be case insensitive?

Peng howtofly at gmail.com
Tue Aug 6 03:51:14 CEST 2013


Hi, Michael and Wei-Cheng.

According to RFC4566, we have the following:

An SDP session description consists of a number of lines of text of
the form:
<type>=<value>
where <type> MUST be exactly one case-significant character and
<value> is structured text whose format depends on <type>. In
general, <value> is either a number of fields delimited by a single
space character or a free format string, and is *case-significant*
unless a specific field defines otherwise. Whitespace MUST NOT be
used on either side of the "=" sign.

Since the definition of rtpmap attribute mentions no case-sensivitity, I 
guess
we should assume it to be case-significant.

Peng

On 08/06/2013 04:02 AM, Michael Niedermayer wrote:
> On Mon, Aug 05, 2013 at 07:06:53PM +0800, Wei-Cheng Pan wrote:
>> Hi,
>>
>> I had an rtsp stream like this:
>>
>>
>> SDP:
>> v=0
>> o=RTSP 1375702538 771 IN IP4 0.0.0.0
>> s=RTSP server
>> c=IN IP4 0.0.0.0
>> t=0 0
>> a=charset:Shift_JIS
>> a=range:npt=0-
>> a=control:*
>> a=etag:1234567890
>> m=video 0 RTP/AVP 98
>> b=AS:0
>> a=rtpmap:98 H264/90000
>> a=control:trackID=1
>> a=fmtp:98 packetization-mode=1; profile-level-id=644014; sprop-parameter-
>> sets=J2RAFKwsagUG3lhAAAD6QAA6mAE=,KO4CGLA=
>> m=audio 0 RTP/AVP 0
>> a=control:trackID=4
>> a=rtpmap:0 pcmu/8000
>>
>>
>> because pcmu (see the last line) is in lower case, ff_rtp_codec_id() in
>> libavformat/rtp.c can not match the right codec.
>>
>> This patch is base on tag n2.0.
> patch applied
>
> thanks
>
> [...]
>
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel



More information about the ffmpeg-devel mailing list