[FFmpeg-devel] [PATCH 3/3] lavf/movenc: support iTunes cover art
michaelni at gmx.at
Sat Aug 3 00:34:30 CEST 2013
On Fri, Aug 02, 2013 at 09:51:12PM +0100, Matthieu Bouron wrote:
> On Thu, Aug 01, 2013 at 03:54:45AM +0200, Michael Niedermayer wrote:
> > On Wed, Jul 31, 2013 at 07:25:22PM +0100, Matthieu Bouron wrote:
> > > On Sun, Jul 28, 2013 at 05:28:30PM +0200, Matthieu Bouron wrote:
> > > > On Sat, Jul 27, 2013 at 09:37:25PM +0200, Matthieu Bouron wrote:
> > > > >
> > > > > BTW, updated patch attached (fixing an indentation mistake + return
> > > > > immediately after storing attached pic in mov_write_packet function).
> > > >
> > > > Updated and rebased patch attached (take psp check into account + fix a
> > > > warning).
> > >
> > > Sorry to bring this up again, but i would like to know if this patch has
> > > any chances to be accepted since the tradeoff of this feature is
> > > "instrusive" code (required to discard apic streams from being referenced
> > > as mov/mp4 tracks).
> > >
> > > Reviews and comments welcomed :)
> > If you take over maintaince of the mov muxer then you can just push
> > the change to your repository and ask me to merge it.
> > I already maintain quite abit of code and loosing the 1:1 relation
> > of streams in a moderately complex muxer has the potential of
> > increasing the maintaince burden for that code. Iam thus not entirely
> > happy about that ...
> > So basically iam happy to apply this but it must not increas the
> > maintaince burden on my side. the mov muxer either should get a
> > new maintainer or some other part of the codebase that i maintain
> > should get a new maintainer or some other responsibility i have should
> > be taken over by someone else.
> Which other parts of the codebase require a maintainer ?
see MAINTAINERS (anything that doesnt list a maintainer or lists
developers who have been inactive for longer than a year surely need
a new maintainer)
also if you spot inaccuracies in the MAINTAINERS file dont hesitate
to fix them
> My knowledge of the mov/mp4 formats is far from perfect but I would be
> happy to take maintenance over it if it can help.
mov/mp4 is a important format and the current lack of a active
maintainer for it is a real problem, so yes it should help quite a bit
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel