[FFmpeg-devel] [Read EXIF metadata 1/5] Refactor TIFF tag related functions to share the code.

[Michael Niedermayer]

On Fri, Aug 02, 2013 at 02:22:31PM +0200, Thilo Borgmann wrote:
> Am 02.08.13 13:11, schrieb Michael Niedermayer:
> > On Fri, Aug 02, 2013 at 09:52:17AM +0200, Thilo Borgmann wrote:
> >> Am 02.08.13 03:08, schrieb Michael Niedermayer:
> >>> On Tue, Jul 30, 2013 at 08:32:40PM +0200, Thilo Borgmann wrote:
> >>>> ---
> >>>>  libavcodec/tiff.c |  134 +++++++++++++++++++++++++++++------------------------
> >>>>  libavcodec/tiff.h |   15 ++++++
> >>>>  2 files changed, 89 insertions(+), 60 deletions(-)
> >>>> [...]
> >>> it appears that this patch is mangled somehow
> >>> git says
> >>> fatal: corrupt patch at line 24
> >>
> >> Resending patches 2/5 and 5/5. "git am" now works for me for all patches.
> 
> > 1/5 needs an update too
> 
> I pulled the newest version and reapplied with "git am" without problems. I'm
> applying the first patch again as a file - I hope this fixes it...
> 
> > also lib internal non static functions need an ff_ prefix
> 
> Going to fix that in the next iteration of the patches, as well as Paul's
> remarks, thanks.

[...]

> @@ -190,4 +191,18 @@ typedef struct TiffGeoTagNameType {
>      const enum TiffGeoTagType type;
>  } TiffGeoTagNameType;
>  
> +int  tiff_decode_header(GetByteContext *gb, int *le, int *ifd_offset);
> +void tiff_read_tag_data(GetByteContext *gb, int le, unsigned *tag, unsigned *type, unsigned *count, unsigned *offset);
> +void tiff_seek_tag_value(GetByteContext *gb, unsigned type, unsigned count, unsigned offset);
> +
> +unsigned tget_short(GetByteContext *gb, int le);
> +unsigned tget_long(GetByteContext *gb, int le);
> +
> +int tiff_add_doubles_metadata(int count, const char *name, const char *sep,
> +                              GetByteContext *gb, int le, AVDictionary **metadata);
> +int tiff_add_shorts_metadata(int count, const char *name, const char *sep,
> +                             GetByteContext *gb, int le, AVDictionary **metadata);
> +int tiff_add_string_metadata(int count, const char *name,
> +                             GetByteContext *gb, int le, AVDictionary **metadata);
> +

a short description (maybe 1 line) for each non static function,
describing what they do exactly could be added

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130802/e45bd948/attachment.asc>