[FFmpeg-devel] [PATCH] libavfilter/unsharp: add opencl unsharp filter

[Wei Gao]

Hi

Thanks for reviewing, some explanations are as follows:

Best regards


2013/4/24 Stefano Sabatini <stefasab at gmail.com>

> On date Tuesday 2013-04-23 14:30:41 +0800, Wei Gao encoded:
> [...]
> > From 7eaeb25facbfae38cf6e13d074be8eecdb669df7 Mon Sep 17 00:00:00 2001
> > From: highgod0401 <highgod0401 at gmail.com>
> > Date: Tue, 23 Apr 2013 14:26:23 +0800
> > Subject: [PATCH 1/2] lavu/opencl:add opencl set param function
> >
>
> > +        if (res & (~0xFF))
> > +            temp_dst[x + y * temp_dst_stride] = (-res) >> 31;
> > +        else
> > +            temp_dst[x + y * temp_dst_stride] = res;
>
> is this equivalent to av_clip_uint8 ?
>
yes, but I can't use it directly, because these code will be compiled in
GPU, and the code is not long, so I wrote it directly.

>
>
> > +    } else {
> > +        temp_dst[x + y * temp_dst_stride] = temp_src[x + y *
> temp_src_stride];
> > +    }
> > +}
>
> please verify that the output is bit-exact with C-code unsharp.
>
the md5 code is the same as follows:
command:
ffmpeg -i ./testfile/blueangels.m4v -vf "unsharp=opencl=1:ca=1" -an -f md5
./testfile/kernel_md5.txt -benchmark -report
ffmpeg -i ./testfile/blueangels.m4v -vf "unsharp=opencl=0:ca=1" -an -f md5
./testfile/kernel_md5.txt -benchmark -report
kernel md5: MD5=de6a146680e3f8f2b5f3cf72d30794b8
C code md5:MD5=de6a146680e3f8f2b5f3cf72d30794b8

>
>
> Overall, very nice work.
> --
> FFmpeg = Forgiving & Formidable Moronic Ponderous Enhanced Gadget
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>