[FFmpeg-devel] [PATCH] lavf/gifdec: add loop support.

[Don Moir]

----- Original Message ----- 
From: "Paul B Mahol" <onemda at gmail.com>
To: "FFmpeg development discussions and patches" <ffmpeg-devel at ffmpeg.org>
Sent: Saturday, April 20, 2013 7:39 AM
Subject: Re: [FFmpeg-devel] [PATCH] lavf/gifdec: add loop support.


> On 4/20/13, Don Moir <donmoir at comcast.net> wrote:
>>>On Thu, Apr 18, 2013 at 11:50:01PM +0000, Paul B Mahol wrote:
>>>> On 4/18/13, Clement Boesch <ubitux at gmail.com> wrote:
>>>> > ---
>>>> > Still missing FATE update (need to add -ignore_loop to them), but I'm
>>>> > waiting for review on the patch to rework the tests.
>>>>
>>>> I would prefer that default is to not loop at all.
>>>>
>>
>>>As you wish, disabled by default. Can be changed later easily if
>>>necessary.
>>
>> disabled by default is good since app has a convienent way of breaking or
>> continuing but if total_iter is not available to app then
>> it does not know what the intended loop value is.
>>
>> Also you might want to check that there are at least 2 frames if ignore_loop
>> is false. While total_iter should not be set if there
>> is only one frame it could be.
>>
>> Again, you don't need ignore loop. app just needs total_iter so it has a way
>> of knowing and can do whatever.
> 
> That could be exported as metadata.

The apng parallel is 'png_get_num_plays' and it's up to app to loop or not. So metadata for ffmpeg would be good.