[FFmpeg-devel] [PATCH] [PROPOSAL] Do not return immediately the result of a probe if we are still probing inside a possible ID3v2 tag.

Michael Niedermayer michaelni at gmx.at
Thu Apr 18 23:50:42 CEST 2013


On Thu, Apr 18, 2013 at 01:05:37PM -0700, Thierry Foucu wrote:
> On Thu, Apr 18, 2013 at 12:07 PM, Michael Niedermayer <michaelni at gmx.at>wrote:
> 
> > On Thu, Apr 18, 2013 at 10:57:55AM -0700, Thierry Foucu wrote:
> > > Some mp3 files have a lot of ID3v2 Tag which could match  some other
> > > probe and return invalid format. With this change, we are trying to
> > > check if we probe pass the Id3v2 tag before returning.
> > > ---
> > >  libavformat/utils.c | 37 ++++++++++++++++++++++++++++---------
> > >  1 file changed, 28 insertions(+), 9 deletions(-)
> >
> > This breaks fate-pva-demux
> >
> > Sorry, should have run fate..
> 
> 
> > can you share a file that needs this change ?
> >
> 
> Sent you a private email with the file.

fixed probing of that file

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130418/caabc4ad/attachment.asc>


More information about the ffmpeg-devel mailing list