[FFmpeg-devel] [PATCH] lavfi/select: factorize options definition between select and aselect

[Stefano Sabatini]

On date Tuesday 2013-04-16 22:58:05 +0200, Clément Bœsch encoded:
> On Mon, Apr 15, 2013 at 09:03:05PM +0200, Stefano Sabatini wrote:
> > ---
> >  libavfilter/f_select.c |   35 ++++++++++++++++-------------------
> >  1 file changed, 16 insertions(+), 19 deletions(-)
[...]
> > +DEFINE_OPTIONS(select, VIDEO);
> >  AVFILTER_DEFINE_CLASS(select);
> >  
> 
> I would use:
> 
>     #define FLAGS AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_FILTERING_PARAM
>     DEFINE_OPTIONS(select, FLAGS);
> 
>     #define AFLAGS AV_OPT_FLAG_AUDIO_PARAM|AV_OPT_FLAG_FILTERING_PARAM
>     DEFINE_OPTIONS(aselect, AFLAGS);
> 
> ...and simplify the macro to make it more readable... but consider it as a
> mater of preferences.
> 
> Patch is OK

Slightly changed and pushed, thanks.
-- 
FFmpeg = Fantastic & Forgiving Mastodontic Peaceless Extravagant Guru