[FFmpeg-devel] [PATCH] lavfi: add smptehdbars source

[Paul B Mahol]

On 4/12/13, Stefano Sabatini <stefasab at gmail.com> wrote:
> On date Thursday 2013-04-11 22:44:15 +0000, Paul B Mahol encoded:
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  doc/filters.texi           |   5 +-
>>  libavfilter/Makefile       |   1 +
>>  libavfilter/allfilters.c   |   1 +
>>  libavfilter/vsrc_testsrc.c | 172
>> ++++++++++++++++++++++++++++++++++++++-------
>>  4 files changed, 151 insertions(+), 28 deletions(-)
>
> Reminder: minor bump, Changelog entry
>

[...]

>> +static void smptehdbars_fill_picture(AVFilterContext *ctx, AVFrame
>> *picref)
>>  {
>> -    AVFilterContext *ctx = outlink->src;
>>      TestSourceContext *test = ctx->priv;
>
>> +    int d_w, r_w, r_h, l_w, i, tmp, x = 0, y = 0;
>
> Nit: better names or a comment may help here (same for regular smptebars)

That is not much of point, as they just keep some calculated values
for width/height of bar at certain location ...

>
>> +    const AVPixFmtDescriptor *pixdesc =
>> av_pix_fmt_desc_get(picref->format);
>>

[...]

>
> Looks good to me assuming it has been tested, adding a test for it may
> be useful (although possibly overkill), thanks.
> --
> FFmpeg = Fierce and Fast Murdering Philosophical Extroverse Gladiator
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>