[FFmpeg-devel] [PATCH 1/3] lavu: add helper functions for integer lists.
nicolas.george at normalesup.org
Sat Apr 13 12:07:44 CEST 2013
Le duodi 22 germinal, an CCXXI, Stefano Sabatini a écrit :
> Note, please send updated patches as attachment to the previous
> review, this helps me to manage the various patches.
I thought I did, sorry. I sent the next series separately because they do
not relate to the bulk of the patches.
> Nit: (only sizes 1, 2, 4, or 8 are supported)
I do not think it makes it more readable.
> Maybe mention something along the lines of:
> The size in bytes of the list is set in the obj field immediately next
> after the pointer to the set list.
> It was not obvious (at least for me).
IMHO, people who use the function do not need to know that, and people who
implement objects using this already know it from the documentation of
> Couldn't this overflow?
Patch sent to address that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel