[FFmpeg-devel] [PATCH 3/3] [APPROVED] ffmpeg: use options for abuffersink.

[Michael Niedermayer]

On Thu, Apr 11, 2013 at 02:58:08PM +0200, Nicolas George wrote:
> Also remove unused buffersink_params.
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
[...]
> @@ -369,18 +367,15 @@ static int configure_output_audio_filter(FilterGraph *fg, OutputFilter *ofilter,
>      char *sample_fmts, *sample_rates, *channel_layouts;
>      char name[255];
>      int ret;
> -    AVABufferSinkParams *params = av_abuffersink_params_alloc();
>  
> -    if (!params)
> -        return AVERROR(ENOMEM);
> -    params->all_channel_counts = 1;
>      snprintf(name, sizeof(name), "output stream %d:%d", ost->file_index, ost->index);
>      ret = avfilter_graph_create_filter(&ofilter->filter,
>                                         avfilter_get_by_name("abuffersink"),
> -                                       name, NULL, params, fg->graph);
> -    av_freep(&params);
> +                                       name, NULL, NULL, fg->graph);

a bit off topic but
libavdevice/lavfi.c uses opaque too, and needs to be changed too

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130412/cfdf3bda/attachment.asc>