[FFmpeg-devel] [PATCH] lavfi/overlay: add process_command callback

[Stefano Sabatini]

On date Friday 2013-02-22 15:58:46 +0100, Stefano Sabatini encoded:
> On date Wednesday 2013-02-20 14:49:11 +0000, Paul B Mahol encoded:
> > On 2/19/13, Stefano Sabatini <stefasab at gmail.com> wrote:
> > > ---
> > >  doc/filters.texi         |   14 ++++++++++++
> > >  libavfilter/vf_overlay.c |   53
> > > ++++++++++++++++++++++++++++++----------------
> > >  2 files changed, 49 insertions(+), 18 deletions(-)
> [...]
> > > +static int process_command(AVFilterContext *ctx, const char *cmd, const
> > > char *args,
> > > +                           char *res, int res_len, int flags)
> > > +{
> > > +    OverlayContext *over = ctx->priv;
> > > +
> > > +    if      (!strcmp(cmd, "x"))
> > > +        return configure_expr(&over->x_pexpr, args, ctx);
> > > +    else if (!strcmp(cmd, "y"))
> > > +        return configure_expr(&over->y_pexpr, args, ctx);
> > > +    else if (!strcmp(cmd, "enable"))
> > > +        return configure_expr(&over->enable_pexpr, args, ctx);
> > > +    else
> > > +        return AVERROR(ENOSYS);
> > 
> 
> > Why ENOSYS? Isn't EINVAL better?
> 
> That's what is used in the other filters.

Updated and pushed with some fixes.
-- 
FFmpeg = Fostering Frightening Multimedia Ponderous Erotic Gnome