[FFmpeg-devel] [PATCH]Do not redefine av_restrict
h.leppkes at gmail.com
Mon Apr 8 22:29:21 CEST 2013
On Wed, Sep 19, 2012 at 9:35 PM, Reimar Döffinger
<Reimar.Doeffinger at gmx.de>wrote:
> On Wed, Sep 19, 2012 at 11:33:25AM -0700, Ronald S. Bultje wrote:
> > On Wed, Sep 19, 2012 at 11:00 AM, Hendrik Leppkes <h.leppkes at gmail.com>
> > > On Wed, Sep 19, 2012 at 7:55 PM, Ronald S. Bultje <rsbultje at gmail.com
> > >> On Wed, Sep 19, 2012 at 9:34 AM, Carl Eugen Hoyos <cehoyos at ag.or.at>
> > >> wrote:
> > >> > Attached patch should silence another msvc-warning, to make sure no
> > >> > warnings are hidden in the noise.
> > >> > (Untested.)
> > >> >
> > >> > Please comment, Carl Eugen
> > >>
> > >> If there's two occurrences of av_restrict, shouldn't we fix it by
> > >> removing the one that shouldn't be there?
> > >>
> > >> Where does the second one live?
> > >>
> > >
> > > There is one in avutil attributes.h (in a installed header), and
> > > mplayer started using it right away, and thus people are wary about
> > > removing it.
> > Fuck mplayer, fix the bug.
> It doesn't matter much here, but I have a problem with this "fuck public
> API" attitude.
> That is ignoring that there might be more things not working as
> designed, for example attributes.h also contains av_always_inline and
> av_extern_inline that are protected by the same kind of #ifndef so I
> suspect they might have been intended to be overwritten by config.h as
> Which is one reason why I would have preferred a way that gets
> config.h always included first, but that seems not easily possible.
> Btw.: I can't find any use of av_restrict in MPlayer...
I would like to revisit this and finally be able to clean this up, because
the excessive warning spam is making me mad some days. :)
The API is still kinda unstable after the evil plan merge, and since
mplayer apparently doesn't use this, and public API doesn't use it, who
Can we get rid of the re-definition of av_restrict, basically just remove
it from attributes.h? See attached patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 714 bytes
Desc: not available
More information about the ffmpeg-devel