[FFmpeg-devel] [PATCH 2/3] libavfilter/deshake_opencl: modify deshake calling opencl API 20130408

[Michael Niedermayer]

On Mon, Apr 08, 2013 at 02:52:02PM +0800, Wei Gao wrote:
> 

>  deshake_opencl.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 8460159b89d3b2b2b0587e0ffdfef43cd6ded178  0002-modify-deshake-calling-opencl-API-20130408.patch
> From e3e522cba7f6c4c282751e21a15e090bc6c75072 Mon Sep 17 00:00:00 2001
> From: highgod0401 <highgod0401 at gmail.com>
> Date: Mon, 8 Apr 2013 14:37:29 +0800
> Subject: [PATCH 2/3] modify deshake calling opencl API 20130408
> 
> ---
>  libavfilter/deshake_opencl.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/libavfilter/deshake_opencl.c b/libavfilter/deshake_opencl.c
> index 63d144a..0f6dcc4 100644
> --- a/libavfilter/deshake_opencl.c
> +++ b/libavfilter/deshake_opencl.c
> @@ -98,10 +98,7 @@ int ff_opencl_deshake_init(AVFilterContext *ctx)
>  {
>      int ret = 0;
>      DeshakeContext *deshake = ctx->priv;
> -    AVDictionary *options = NULL;
> -    av_dict_set(&options, "build_options", "-I.", 0);
> -    ret = av_opencl_init(options, NULL);
> -    av_dict_free(&options);
> +    ret = av_opencl_init(NULL);
>      if (ret < 0)
>          return ret;

if you chnage the API in one patch and the calls in another then the
code would not compile between the 2 commits. Thats bad as it
would break git bisect

also couldnt the options parameter become usefull in the future again?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130408/96a0a7b0/attachment.asc>