[FFmpeg-devel] [PATCH]Either set both display_width and display_height to pixeLwidth and pixel_height or none

[Hendrik Leppkes]

On Wed, Apr 3, 2013 at 10:06 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> Hi!
>
> Attached patch fixes ticket #2429 for me.
>
> Please comment, Carl Eugen
>
>
According to the Matroska Spec, DisplayWidth/DisplayHeight have a default
value of PixelWidth/PixelHeight respectively, so its perfectly valid to
only encode one of them in the file to override only one.
ie. i can imaging having a file with Pixel W/H of 1440x1080, and a
DisplayWidth of 1920, giving a result of 1920x1080 for Display W/H, taking
the default into account.

So the current code appears correct.

The one limitation to this rule is that the defaults only apply if
DisplayUnit has the value 0, which is not checked by avformat, maybe this
is the case here?