[FFmpeg-devel] [PATCH]012v decoder, v2

[Paul B Mahol]

On 9/28/12, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Paul B Mahol <onemda <at> gmail.com> writes:
>
>> On 9/27/12, Carl Eugen Hoyos wrote:
>> >
>> > Attached is an updated version of the 012v decoder,
>> > I am still using PIX_FMT_YUV422P16 (because I consider
>> > PIX_FMT_YUV422P10 a deprecated format)
>> >
>> > as do other FFmpeg decoders.
>>
>> This does not make sense. How pixel format can become deprecated?
>
> See the comment in libavutil/pixfmt.h

There is no such comment. And if there is such comment it should be
removed ASAP,
>
>> > As said, I also believe the code looks broken, but it
>> > does decode all samples I have, we will only find out
>> > if the encoder is perhaps broken if this gets
>>
>> What encoder?
>
> The encoder that produced the samples I tested.
>
>> > applied.
>> >
>> > Please comment, Carl Eugen
>>
>> I'm not going to waste my time copy pasting patch, but
>> failure of get_buffer should return proper error code and
>> not -1.
>
> Fixed locally.
>
> Any other comments?
>
> Thank you, Carl Eugen
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>