[FFmpeg-devel] [PATCH 4/5] Add missing version macros to libraries

Stefano Sabatini stefasab at gmail.com
Thu Sep 27 10:31:54 CEST 2012


On date Thursday 2012-09-27 04:35:32 -0300, jamal encoded:
> ---
>  libavdevice/version.h   |    2 ++
>  libavfilter/version.h   |    2 ++
>  libswresample/version.h |    6 ++++++
>  3 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/libavdevice/version.h b/libavdevice/version.h
> index d8aa94f..04c2a16 100644
> --- a/libavdevice/version.h
> +++ b/libavdevice/version.h
> @@ -39,6 +39,8 @@
>                                             LIBAVDEVICE_VERSION_MICRO)
>  #define LIBAVDEVICE_BUILD       LIBAVDEVICE_VERSION_INT
>  
> +#define LIBAVDEVICE_IDENT       "Lavd" AV_STRINGIFY(LIBAVDEVICE_VERSION)
> +
>  /**
>   * FF_API_* defines may be placed below to indicate public API that will be
>   * dropped at a future version bump. The defines themselves are not part of
> diff --git a/libavfilter/version.h b/libavfilter/version.h
> index 3d3d1c9..033af90 100644
> --- a/libavfilter/version.h
> +++ b/libavfilter/version.h
> @@ -40,6 +40,8 @@
>                                             LIBAVFILTER_VERSION_MICRO)
>  #define LIBAVFILTER_BUILD       LIBAVFILTER_VERSION_INT
>  
> +#define LIBAVFILTER_IDENT       "Lavfi" AV_STRINGIFY(LIBAVFILTER_VERSION)
> +
>  /**
>   * FF_API_* defines may be placed below to indicate public API that will be
>   * dropped at a future version bump. The defines themselves are not part of
> diff --git a/libswresample/version.h b/libswresample/version.h
> index 0f610bc..2031acd 100644
> --- a/libswresample/version.h
> +++ b/libswresample/version.h
> @@ -35,5 +35,11 @@
>  #define LIBSWRESAMPLE_VERSION_INT  AV_VERSION_INT(LIBSWRESAMPLE_VERSION_MAJOR, \
>                                                    LIBSWRESAMPLE_VERSION_MINOR, \
>                                                    LIBSWRESAMPLE_VERSION_MICRO)
> +#define LIBSWRESAMPLE_VERSION      AV_VERSION(LIBSWRESAMPLE_VERSION_MAJOR, \
> +                                              LIBSWRESAMPLE_VERSION_MINOR, \
> +                                              LIBSWRESAMPLE_VERSION_MICRO)
> +#define LIBSWRESAMPLE_BUILD        LIBSWRESAMPLE_VERSION_INT
> +
> +#define LIBSWRESAMPLE_IDENT        "SwR" AV_STRINGIFY(LIBSWRESAMPLE_VERSION)

LGTM.

Again new symbols should be marked by a minor bump (so applications
know when they can refer them) and advertised on APIchanges.
-- 
FFmpeg = Fantastic & Freak Multimedia Portable Elitarian Genius


More information about the ffmpeg-devel mailing list