[FFmpeg-devel] [PATCH] lavf/oggdec: check for begin-of-stream flag in case of chained streams.

[Clément Bœsch]

On Sat, Sep 22, 2012 at 12:26:35AM +0200, Michael Niedermayer wrote:
> On Fri, Sep 21, 2012 at 10:39:02PM +0200, Clément Bœsch wrote:
> > Fix Ticket #1617, revealing a regression I introduced in 8f3eebd.
> > ---
> > Difference from the latest attempt: as requested by Michael, I needed to make
> > sure no stream is added in between Ogg context save/restore operations (because
> > it would likely lead to a mismatch between ogg->nstreams and
> > AVFormatContext->nb_streams after the restore op). Before this patch, checking
> > for ogg->headers was preventing this: ogg->headers is always set before any ogg
> > save/restore (though, it was also preventing from creating the stream when
> > necessary).
> > 
> > But I still don't get how the ogg_new_stream() is never called between
> > ogg_save/restore calls (the ogg->state I added in ogg_new_stream is never
> > triggered with my tests), while it obviously calls the same read pages and
> > packets function as usual...
> > ---
> >  libavformat/oggdec.c | 22 +++++++++++++++++++++-
> >  libavformat/oggdec.h |  1 +
> >  2 files changed, 22 insertions(+), 1 deletion(-)
> 
> LGTM
> 

Thank you for your patience & review on this patch. Commit commented and
applied.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120922/db66639f/attachment.asc>