[FFmpeg-devel] [PATCH] mingw: Use avprive_vsnprintf in bprint

[jamal]

On 21/09/12 2:06 PM, Derek Buitenhuis wrote:
>> If neither that nor libavutil/os_support.h are viable options, then we could just force the inclusion of some new header in CFLAGS, which is what Bultje originally intended and what's being done with MSVC for other stuff.
>> It's hackish and i personally don't like it, but it's acceptable.
> 
> Is libavutil/os_support.h included by everything that could need it (implicitly or otherwise)?
> 
libavutil/os_support.h would have to be created and included in about nine files if we only use it for vnsprintf (Mingw64).
If we also use it for snprintf (MSVC) to get rid of the -D stuff then it would end up being as intrusive as using avstring.h/c (Too many files would need to be changed), so not really an option.

The other solution is creating a new header in the compat folder and forcing its inclusion when compiling for Mingw. The check for Mingw64 < 3 could be either done in that header, or in the configure script so the header gets included only when needed.
In short, MSVC using -Dsnprintf and -Dvsnprintf with no headers as it's right now, and Mingw64 using -includecompat/someheader.h.