[FFmpeg-devel] [PATCH] mingw: Use avprive_vsnprintf in bprint

[Derek Buitenhuis]

On 20/09/2012 3:53 PM, jamal wrote:
> I think HAVE_WINDOWS_H should work for that.

We already have something like HAVE_MSVCRT or so. There's no reason for
an extra check. Heck, we may as well just use _WIN32.

> Nonetheless, Mingw32's vsnprintf works fine. The buggy one is Mingw64's (both 32 and 64 bits) before rev 4663 as you mentioned, so we should make sure to use avpriv_vsnprintf only with Mingw64 v1.0 and v2.0.

I'd rather just use avpriv_vsnprint everywhere instead of extra version checks.
Anyone who still uses pre-xp OSes is not fit to be using a computer.

> This is important because Mingw32 is the only remaining toolchain that compiles for Win98/NT4 and Win2K, so forcing the usage of avpriv_vsnprintf with it would mean the end of ffmpeg's support for those versions.

See above.

> And regarding the prototypes, i still think that a new libavutil/os_support.h header for this would be a good idea.

I am certain this will be frowned upon... see all the bikeshedding about where the implementation was
placed in the first place...

- Derek