[FFmpeg-devel] [PATCH]Do not redefine av_restrict

[Reimar Döffinger]

On Wed, Sep 19, 2012 at 11:33:25AM -0700, Ronald S. Bultje wrote:
> On Wed, Sep 19, 2012 at 11:00 AM, Hendrik Leppkes <h.leppkes at gmail.com> wrote:
> > On Wed, Sep 19, 2012 at 7:55 PM, Ronald S. Bultje <rsbultje at gmail.com>wrote:
> >> On Wed, Sep 19, 2012 at 9:34 AM, Carl Eugen Hoyos <cehoyos at ag.or.at>
> >> wrote:
> >> > Attached patch should silence another msvc-warning, to make sure no real
> >> > warnings are hidden in the noise.
> >> > (Untested.)
> >> >
> >> > Please comment, Carl Eugen
> >>
> >> If there's two occurrences of av_restrict, shouldn't we fix it by
> >> removing the one that shouldn't be there?
> >>
> >> Where does the second one live?
> >>
> >
> > There is one in avutil attributes.h (in a installed header), and apparently
> > mplayer started using it right away, and thus people are wary about
> > removing it.
> 
> Fuck mplayer, fix the bug.

It doesn't matter much here, but I have a problem with this "fuck public
API" attitude.
That is ignoring that there might be more things not working as
designed, for example attributes.h also contains av_always_inline and
av_extern_inline that are protected by the same kind of #ifndef so I
suspect they might have been intended to be overwritten by config.h as
well.
Which is one reason why I would have preferred a way that gets
config.h always included first, but that seems not easily possible.
Btw.: I can't find any use of av_restrict in MPlayer...