[FFmpeg-devel] [PATCH] ffprobe: Add a few common disposition cases

[Derek Buitenhuis]

On 18/09/2012 2:35 PM, Reimar Döffinger wrote:
>> I do not think it should be a separate function, and I do not think it makes it clearer than having it
>> under the media type where it belongs.
>>
>> I respectfully disagree.
> 
> Well, I think it belongs more to the disposition checks than a specific media type.

I've moved it up with the rest, but I am still against it being a separate function.

>> If it gets set for anything but a video stream, then it is wrong, and a bug. "Attached Pic" on anything
>> but video is hilariously stupid.
> 
> Mostly because I'd consider "attached picture" a naming error that needlessly limits what it can be used for.
> What it really means "metadata that we for some reason export as stream".
> And that has no real reason to be specific to video streams...

I think using it with this meaning is wrong. Create a different disposition for that. This should
only, and specifically be used to attached pictures/thumbs. In fact, this -only- seems to be used
for for thumbnails/pictures in the codebase, which is exactly what its name says. I am curious
where you pulled this "metadata that we for some reason export as stream" from...

> More specifically, my minor concern is that by putting this in a separate place the chance that we miss updating it if we change that name (while keeping the attached_picture for compatibility) is higher.

It would be a bad design choice to do this in the first place, and not something I think we
should consider. I am very much against changing and, as we so love to do, making it overly generic
(all metadata) and quite useless as a disposition.

> Anyway the patch is not worth that much discussion, ok from my side if I can't convince you.

I think I've addressed everything in this patch, as it stands. The rest would lie outside its scope.

I'll push it if you or someone else OKs after this email.

- Derek