[FFmpeg-devel] [PATCH]Silence a msvc warning

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Sep 18 20:00:43 CEST 2012


On 18 Sep 2012, at 18:34, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> On 18/09/2012 12:17 PM, Carl Eugen Hoyos wrote:
>> msvc currently often warns:
>> warning C4554: '>>' : check operator precedence for possible error; use 
>> parentheses to clarify precedence
> 
> This is rather dumb indeed. Patch looks OK to me.
> 
>> More important would be to silence:
>> warning C4005: 'av_restrict' : macro redefinition
>>        libavutil\attributes.h(66) : see previous definition of 'av_restrict'
>> But I am not sure where this should be done.
> 
> Please see this thread:
> 
> http://ffmpeg.org/pipermail/ffmpeg-devel/2012-September/130621.html

While that's maybe not a bad idea anyway, I think here it just might hide a real issue:
some file includes config.h after it already included attributes.h. Without further investigation, that does not seem right to me.


More information about the ffmpeg-devel mailing list