[FFmpeg-devel] [PATCH]Silence a msvc warning

[Hendrik Leppkes]

On Tue, Sep 18, 2012 at 6:40 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> Derek Buitenhuis <derek.buitenhuis <at> gmail.com> writes:
>
> > On 18/09/2012 12:17 PM, Carl Eugen Hoyos wrote:
> > > msvc currently often warns:
> > > warning C4554: '>>' : check operator precedence for possible error; use
> > > parentheses to clarify precedence
> >
> > This is rather dumb indeed. Patch looks OK to me.
>
> Patch applied.
>
> I found another one that I suspect you want to silence:
> libavcodec\get_bits.h(255) : warning C4189: 're_size_plus8' :
> local variable is initialized but not referenced
>
> If you agree, I will commit a patch.
>
> Thank you, Carl Eugen
>
>
Arbitrarily disabling warnings just because they show up a lot is not a
solution to any problem.
This variable in particular is marked av_unused, which apparently is just
void for MSVC, so instead try to find a way to make av_unused work, instead
of disabling the whole warning, eventually hiding real warnings.

- Hendrik