[FFmpeg-devel] [PATCH] lavf/utils: fix ISO8601 date generation, after the switch to av_small_strptime()

Stefano Sabatini stefasab at gmail.com
Mon Sep 17 12:58:16 CEST 2012


On date Monday 2012-09-17 06:41:34 +0200, Michael Niedermayer encoded:
> On Mon, Sep 17, 2012 at 01:04:03AM +0200, Stefano Sabatini wrote:
[...]
> > > To elaborate on my point ...
> > > the way i interpret the posix spec is that spaces in
> > > the format specification must match 0+ spaces, while av_small_strptime
> > > seems to treat it as =1
> > 
> > Yes, I interpret it the same way, thanks for noticing.
> > 
> > Patch updated, now I don't know if we should let av_small_strptime()
> > rely on locale-specific isspace().
> 
> i dunno either, avoiding it might be better
> otherwise patches LGTM
> 
> thanks

Applied this variant (I see isspace() is used on other parts of
libavutil and FFmpeg), can be changed later if we see the need.
-- 
FFmpeg = Free Fast Most Picky Evil Generator


More information about the ffmpeg-devel mailing list