[FFmpeg-devel] [PATCH 7/9] lavf/oggdec: remove inappropriate error message.

[Michael Niedermayer]

On Sat, Sep 15, 2012 at 02:55:38AM +0200, Clément Bœsch wrote:
> On Sat, Sep 15, 2012 at 02:21:16AM +0200, Michael Niedermayer wrote:
> > On Sat, Sep 15, 2012 at 01:20:46AM +0200, Clément Bœsch wrote:
> > > idx contains the correct error code and will raise the appropriate
> > > error message.
> > > ---
> > >  libavformat/oggdec.c | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > 
> > > diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c
> > > index 2c7bbd8..aed49a5 100644
> > > --- a/libavformat/oggdec.c
> > > +++ b/libavformat/oggdec.c
> > > @@ -275,10 +275,8 @@ static int ogg_read_page(AVFormatContext *s, int *sid)
> > >          } else {
> > >              idx = ogg_new_stream(s, serial, 1);
> > >          }
> > > -        if (idx < 0) {
> > > -            av_log (s, AV_LOG_ERROR, "failed to create stream (OOM?)\n");
> > > +        if (idx < 0)
> > >              return idx;
> > > -        }
> > 
> > The reason for the failure would be printed but what failed
> > (failed to create stream) would be lost i think
> > 
> 
> OK. Patch dropped and replaced with the attached one on top of the
> patchset.

LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120915/d2189ad6/attachment.asc>