[FFmpeg-devel] [PATCH 7/9] lavf/oggdec: remove inappropriate error message.

Michael Niedermayer michaelni at gmx.at
Sat Sep 15 02:21:16 CEST 2012


On Sat, Sep 15, 2012 at 01:20:46AM +0200, Clément Bœsch wrote:
> idx contains the correct error code and will raise the appropriate
> error message.
> ---
>  libavformat/oggdec.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c
> index 2c7bbd8..aed49a5 100644
> --- a/libavformat/oggdec.c
> +++ b/libavformat/oggdec.c
> @@ -275,10 +275,8 @@ static int ogg_read_page(AVFormatContext *s, int *sid)
>          } else {
>              idx = ogg_new_stream(s, serial, 1);
>          }
> -        if (idx < 0) {
> -            av_log (s, AV_LOG_ERROR, "failed to create stream (OOM?)\n");
> +        if (idx < 0)
>              return idx;
> -        }

The reason for the failure would be printed but what failed
(failed to create stream) would be lost i think

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120915/d3f7a6ca/attachment.asc>


More information about the ffmpeg-devel mailing list